Commit f6f33a07d06cbd5c87d28b979106fa5105ba7bf8

Authored by YunaiV
1 parent b75d7776

code review:订单评论、订单积分的变更

yudao-module-member/yudao-module-member-biz/src/main/java/cn/iocoder/yudao/module/member/service/point/MemberPointRecordServiceImpl.java
@@ -5,8 +5,6 @@ import cn.hutool.core.util.ObjectUtil; @@ -5,8 +5,6 @@ import cn.hutool.core.util.ObjectUtil;
5 import cn.hutool.core.util.StrUtil; 5 import cn.hutool.core.util.StrUtil;
6 import cn.iocoder.yudao.framework.common.pojo.PageParam; 6 import cn.iocoder.yudao.framework.common.pojo.PageParam;
7 import cn.iocoder.yudao.framework.common.pojo.PageResult; 7 import cn.iocoder.yudao.framework.common.pojo.PageResult;
8 -import cn.iocoder.yudao.module.member.api.user.MemberUserApi;  
9 -import cn.iocoder.yudao.module.member.api.user.dto.MemberUserRespDTO;  
10 import cn.iocoder.yudao.module.member.controller.admin.point.vo.recrod.MemberPointRecordPageReqVO; 8 import cn.iocoder.yudao.module.member.controller.admin.point.vo.recrod.MemberPointRecordPageReqVO;
11 import cn.iocoder.yudao.module.member.dal.dataobject.point.MemberPointConfigDO; 9 import cn.iocoder.yudao.module.member.dal.dataobject.point.MemberPointConfigDO;
12 import cn.iocoder.yudao.module.member.dal.dataobject.point.MemberPointRecordDO; 10 import cn.iocoder.yudao.module.member.dal.dataobject.point.MemberPointRecordDO;
@@ -43,8 +41,6 @@ public class MemberPointRecordServiceImpl implements MemberPointRecordService { @@ -43,8 +41,6 @@ public class MemberPointRecordServiceImpl implements MemberPointRecordService {
43 private MemberPointConfigService memberPointConfigService; 41 private MemberPointConfigService memberPointConfigService;
44 42
45 @Resource 43 @Resource
46 - private MemberUserApi memberUserApi;  
47 - @Resource  
48 private MemberUserService memberUserService; 44 private MemberUserService memberUserService;
49 45
50 @Override 46 @Override
@@ -52,12 +48,12 @@ public class MemberPointRecordServiceImpl implements MemberPointRecordService { @@ -52,12 +48,12 @@ public class MemberPointRecordServiceImpl implements MemberPointRecordService {
52 // 根据用户昵称查询出用户 ids 48 // 根据用户昵称查询出用户 ids
53 Set<Long> userIds = null; 49 Set<Long> userIds = null;
54 if (StringUtils.isNotBlank(pageReqVO.getNickname())) { 50 if (StringUtils.isNotBlank(pageReqVO.getNickname())) {
55 - List<MemberUserRespDTO> users = memberUserApi.getUserListByNickname(pageReqVO.getNickname()); 51 + List<MemberUserDO> users = memberUserService.getUserListByNickname(pageReqVO.getNickname());
56 // 如果查询用户结果为空直接返回无需继续查询 52 // 如果查询用户结果为空直接返回无需继续查询
57 if (CollectionUtils.isEmpty(users)) { 53 if (CollectionUtils.isEmpty(users)) {
58 return PageResult.empty(); 54 return PageResult.empty();
59 } 55 }
60 - userIds = convertSet(users, MemberUserRespDTO::getId); 56 + userIds = convertSet(users, MemberUserDO::getId);
61 } 57 }
62 // 执行查询 58 // 执行查询
63 return recordMapper.selectPage(pageReqVO, userIds); 59 return recordMapper.selectPage(pageReqVO, userIds);