📖 CRM：【还款】code review 还款的代码，补全对应的 todo list

YunaiV
1 parent c6a97515
Showing 6 changed files with 24 additions and 20 deletions
yudao-module-crm/yudao-module-crm-biz/src/main/java/cn/iocoder/yudao/module/crm/service/business/package-info.java
yudao-module-crm/yudao-module-crm-biz/src/main/java/cn/iocoder/yudao/module/crm/service/clue/package-info.java
yudao-module-crm/yudao-module-crm-biz/src/main/java/cn/iocoder/yudao/module/crm/service/product/package-info.java
yudao-module-crm/yudao-module-crm-biz/src/main/java/cn/iocoder/yudao/module/crm/service/receivable/CrmReceivablePlanServiceImpl.java
yudao-module-crm/yudao-module-crm-biz/src/main/java/cn/iocoder/yudao/module/crm/service/receivable/CrmReceivableServiceImpl.java
yudao-module-crm/yudao-module-crm-biz/src/main/java/cn/iocoder/yudao/module/crm/service/receivable/package-info.java
-/**
- * 商机（销售机会）
- */
-package cn.iocoder.yudao.module.crm.service.business;
-/**
- * 线索
- */
-package cn.iocoder.yudao.module.crm.service.clue;
-/**
- * 产品表
- */
-package cn.iocoder.yudao.module.crm.service.product;
@@ -52,7 +52,10 @@ public class CrmReceivablePlanServiceImpl implements CrmReceivablePlanService {
     private CrmPermissionService crmPermissionService;
  
     @Override
+    // TODO @puhui999：操作日志
     public Long createReceivablePlan(CrmReceivablePlanCreateReqVO createReqVO, Long userId) {
+        // TODO @liuhongfeng：第几期的计算；基于是 contractId + contractDO 的第几个还款
+        // TODO @liuhongfeng contractId：校验合同是否存在
         // 插入
         CrmReceivablePlanDO receivablePlan = CrmReceivablePlanConvert.INSTANCE.convert(createReqVO);
         receivablePlan.setFinishStatus(false);
@@ -87,7 +90,9 @@ public class CrmReceivablePlanServiceImpl implements CrmReceivablePlanService {
  
     @Override
     @CrmPermission(bizType = CrmBizTypeEnum.CRM_RECEIVABLE_PLAN, bizId = "#updateReqVO.id", level = CrmPermissionLevelEnum.WRITE)
+    // TODO @puhui999：操作日志
     public void updateReceivablePlan(CrmReceivablePlanUpdateReqVO updateReqVO) {
+        // TODO @liuhongfeng：如果已经有对应的还款，则不允许编辑；
         // 校验存在
         validateReceivablePlanExists(updateReqVO.getId());
  
@@ -136,6 +141,7 @@ public class CrmReceivablePlanServiceImpl implements CrmReceivablePlanService {
         return receivablePlanMapper.selectPageByCustomerId(pageReqVO);
     }
  
+    // TODO @puhui999：这个没有 transfer 接口；可能是的哈
     @Override
     public void transferReceivablePlan(CrmReceivablePlanTransferReqVO reqVO, Long userId) {
         // 1 校验回款计划是否存在
@@ -53,10 +53,10 @@ public class CrmReceivableServiceImpl implements CrmReceivableService {
     @Resource
     private CrmPermissionService crmPermissionService;
  
-    // TODO @liuhongfeng：创建还款后，是不是什么时候，要更新 plan？
     @Override
+    // TODO @puhui999：操作日志
     public Long createReceivable(CrmReceivableCreateReqVO createReqVO) {
-        // 插入
+        // 插入还款
         CrmReceivableDO receivable = CrmReceivableConvert.INSTANCE.convert(createReqVO);
         if (ObjectUtil.isNull(receivable.getAuditStatus())) {
             receivable.setAuditStatus(CommonStatusEnum.ENABLE.getStatus());
@@ -64,15 +64,17 @@ public class CrmReceivableServiceImpl implements CrmReceivableService {
         receivable.setAuditStatus(CrmAuditStatusEnum.DRAFT.getStatus());
  
         // TODO @liuhongfeng：一般来说，逻辑的写法，是要先检查，后操作 db；所以，你这个 check 应该放到  CrmReceivableDO receivable 之前；
-        // 校验
         checkReceivable(receivable);
  
         receivableMapper.insert(receivable);
+
+        // TODO @liuhongfeng：需要更新关联的 plan
         return receivable.getId();
     }
  
     // TODO @liuhongfeng：这里的括号要注意排版；
     private void checkReceivable(CrmReceivableDO receivable) {
+        // TODO @liuhongfeng：校验 no 的唯一性
         // TODO @liuhongfeng：这个放在参数校验合适
         if (ObjectUtil.isNull(receivable.getContractId())) {
             throw exception(CONTRACT_NOT_EXISTS);
@@ -96,17 +98,29 @@ public class CrmReceivableServiceImpl implements CrmReceivableService {
     }
  
     @Override
+    // TODO @puhui999：操作日志
+    // TODO @puhui999：权限校验
     public void updateReceivable(CrmReceivableUpdateReqVO updateReqVO) {
         // 校验存在
         validateReceivableExists(updateReqVO.getId());
+        // TODO @liuhongfeng：只有在草稿、审核中，可以提交修改
  
-        // 更新
+        // 更新还款
         CrmReceivableDO updateObj = CrmReceivableConvert.INSTANCE.convert(updateReqVO);
         receivableMapper.updateById(updateObj);
+
+        // TODO @liuhongfeng：需要更新关联的 plan
     }
  
+    // TODO @liuhongfeng：缺一个取消合同的接口；只有草稿、审批中可以取消；CrmAuditStatusEnum
+
+    // TODO @liuhongfeng：缺一个发起审批的接口；只有草稿可以发起审批；CrmAuditStatusEnum
+
     @Override
+    // TODO @puhui999：操作日志
+    // TODO @puhui999：权限校验
     public void deleteReceivable(Long id) {
+        // TODO @liuhongfeng：如果被 CrmReceivablePlanDO 所使用，则不允许删除
         // 校验存在
         validateReceivableExists(id);
         // 删除
-/**
- * 回款
- */
-package cn.iocoder.yudao.module.crm.service.receivable;