【代码评审】Bpm：更多设置-自定义标题

YunaiV
1 parent e99eb5c8
Showing 3 changed files with 5 additions and 0 deletions
yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/controller/admin/definition/vo/model/BpmModelMetaInfoVO.java
yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/framework/flowable/core/enums/BpmnVariableConstants.java
yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/service/task/BpmProcessInstanceServiceImpl.java
@@ -101,6 +101,7 @@ public class BpmModelMetaInfoVO {
  
     }
  
+    // TODO @lesan：TitleSetting 会不会更好。因为 Custom 和 Setting 有点重叠
     @Schema(description = "标题设置")
     @Data
     @Valid
@@ -50,8 +50,11 @@ public class BpmnVariableConstants {
      * @see <a href="https://blog.csdn.net/weixin_42065235/article/details/126039993">Flowable/Activiti之SkipExpression 完成自动审批</a>
      */
     public static final String PROCESS_INSTANCE_SKIP_EXPRESSION_ENABLED = "_FLOWABLE_SKIP_EXPRESSION_ENABLED";
+
     /**
      * 流程实例的变量 - 流程开始时间
+     *
+     * 【非存储变量】用于部分需要 format 的场景，例如说：流程实例的自定义标题
      */
     public static final String PROCESS_START_TIME = "PROCESS_START_TIME";
     /**
@@ -621,6 +621,7 @@ public class BpmProcessInstanceServiceImpl implements BpmProcessInstanceService 
         BpmModelMetaInfoVO.CustomTitleSetting customTitleSetting = processDefinitionInfo.getCustomTitleSetting();
         if (customTitleSetting != null && Boolean.TRUE.equals(customTitleSetting.getEnable())) {
             AdminUserRespDTO user = adminUserApi.getUser(userId);
+            // TODO @lesan：new HashMap 会更好哈。clone 感觉反射，不一定合适。
             Map<String, Object> cloneVariables = ObjectUtil.clone(variables);
             cloneVariables.put(BpmnVariableConstants.PROCESS_INSTANCE_VARIABLE_START_USER_ID, user.getNickname());
             cloneVariables.put(BpmnVariableConstants.PROCESS_START_TIME, DateUtil.now());