Commit 9a5f08536906389976d98d7db9ec354585b4f1fb
1 parent
67aaf288
code review 支付问题
Showing
2 changed files
with
2 additions
and
2 deletions
yudao-admin-server/src/main/java/cn/iocoder/yudao/adminserver/modules/pay/controller/app/PayAppController.java
| ... | ... | @@ -109,6 +109,7 @@ public class PayAppController { |
| 109 | 109 | // 得到所有的应用编号,查出所有的通道 |
| 110 | 110 | Collection<Long> payAppIds = CollectionUtils.convertList(pageResult.getList(), PayAppDO::getId); |
| 111 | 111 | List<PayChannelDO> channels = channelService.getChannelListByAppIds(payAppIds); |
| 112 | + // TODO @aquan:可以基于 appId 简历一个 multiMap。这样下面,直接 get 到之后,CollUtil buildSet 即可 | |
| 112 | 113 | Iterator<PayChannelDO> iterator = channels.iterator(); |
| 113 | 114 | |
| 114 | 115 | // 得到所有的商户信息 | ... | ... |
yudao-admin-server/src/main/java/cn/iocoder/yudao/adminserver/modules/pay/service/app/impl/PayAppServiceImpl.java
| ... | ... | @@ -181,10 +181,9 @@ public class PayAppServiceImpl implements PayAppService { |
| 181 | 181 | throw exception(PAY_APP_EXIST_TRANSACTION_ORDER_CANT_DELETE); |
| 182 | 182 | } |
| 183 | 183 | // 查看退款订单 |
| 184 | - if (refundMapper.selectCount(appId, PayRefundStatusEnum.CREATE.getStatus()) > 0) { | |
| 184 | + if (refundMapper.selectCount(appId, PayRefundStatusEnum.CREATE.getStatus()) > 0) { | |
| 185 | 185 | throw exception(PAY_APP_EXIST_TRANSACTION_ORDER_CANT_DELETE); |
| 186 | 186 | } |
| 187 | - | |
| 188 | 187 | } |
| 189 | 188 | |
| 190 | 189 | } | ... | ... |