【代码评审】BPM：触发器 - 表单修改

YunaiV
1 parent f5050807
Showing 5 changed files with 13 additions and 5 deletions
yudao-framework/yudao-common/src/main/java/cn/iocoder/yudao/framework/common/util/json/JsonUtils.java
yudao-module-bpm/yudao-module-bpm-api/src/main/java/cn/iocoder/yudao/module/bpm/enums/definition/BpmTriggerTypeEnum.java
yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/controller/admin/definition/vo/model/simple/BpmSimpleModelNodeVO.java
yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/service/task/trigger/BpmHttpRequestTrigger.java
yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/service/task/trigger/BpmUpdateNormalFormTrigger.java
@@ -206,4 +206,5 @@ public class JsonUtils {
     public static boolean isJsonObject(String str) {
         return JSONUtil.isTypeJSONObject(str);
     }
+
 }
@@ -17,8 +17,7 @@ import java.util.Arrays;
 public enum BpmTriggerTypeEnum implements ArrayValuable<Integer> {
  
     HTTP_REQUEST(1, "发起 HTTP 请求"),
-    UPDATE_NORMAL_FORM(2, "更新流程表单");
-
+    UPDATE_NORMAL_FORM(2, "更新流程表单"); // TODO @jason：FORM_UPDATE
  
     /**
      * 触发器执行动作类型
@@ -345,6 +345,8 @@ public class BpmSimpleModelNodeVO {
         @Valid
         private HttpRequestTriggerSetting httpRequestSetting;
  
+        // TODO @jason：这个要不直接叫 formSetting，更好理解一点哈
+        // TODO @jason：如果搞成 List<NormalFormTriggerSetting>，是不是可以做条件组了？微信讨论哈
         /**
          * 流程表单触发器设置
          */
@@ -376,6 +378,7 @@ public class BpmSimpleModelNodeVO {
              */
             @Schema(description = "请求返回处理设置", example = "[]")
             private List<KeyValue<String, String>> response;
+
         }
  
         @Schema(description = "流程表单触发器设置", example = "{}")
@@ -384,6 +387,8 @@ public class BpmSimpleModelNodeVO {
  
             @Schema(description = "修改的表单字段", example = "userName")
             private Map<String, Object> updateFormFields;
+
         }
+
     }
 }
@@ -81,13 +81,14 @@ public class BpmHttpRequestTrigger implements BpmTrigger {
         }
  
         // 4.1 判断是否需要解析返回值
-        if (StrUtil.isEmpty(responseEntity.getBody()) || !responseEntity.getStatusCode().is2xxSuccessful()
+        if (StrUtil.isEmpty(responseEntity.getBody())
+                || !responseEntity.getStatusCode().is2xxSuccessful()
                 || CollUtil.isEmpty(setting.getResponse())) {
             return;
         }
         // 4.2 解析返回值, 返回值必须符合 CommonResult 规范。
-        CommonResult<Map<String, Object>> respResult = JsonUtils.parseObjectQuietly(responseEntity.getBody(),
-                new TypeReference<>() {});
+        CommonResult<Map<String, Object>> respResult = JsonUtils.parseObjectQuietly(
+                responseEntity.getBody(), new TypeReference<>() {});
         if (respResult == null || !respResult.isSuccess()){
             return;
         }
@@ -9,6 +9,7 @@ import jakarta.annotation.Resource;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Component;
  
+// TODO @jason：改成 BpmFormUpdateTrigger
 /**
  * BPM 更新流程表单触发器
  *
@@ -39,4 +40,5 @@ public class BpmUpdateNormalFormTrigger implements BpmTrigger {
             processInstanceService.updateProcessInstanceVariables(processInstanceId, setting.getUpdateFormFields());
         }
     }
+
 }