BJ_ZTEITS-Developers / parking-cloud-yudao

Commit 91f23dfe7f87a84e5fb1e87010cc79cda9fa6939

Authored by 芋道源码
Committed by GitHub
2 parents ef39c91c 0ec664bb

Merge pull request #1299 from Esctasy2450/codex/fix-im-channel-receiver-binding 

fix(im): 修复频道消息查询接收人列表参数类型不匹配
Inline Side-by-side
Showing 2 changed files with 61 additions and 1 deletions
yudao-module-im/src/main/java/cn/iocoder/yudao/module/im/dal/mysql/message/ImChannelMessageMapper.java
  View file @91f23df
... ... @@ -8,6 +8,7 @@ import cn.iocoder.yudao.module.im.controller.admin.manager.message.vo.channel.Im
8 8 import cn.iocoder.yudao.module.im.dal.dataobject.message.ImChannelMessageDO;
9 9 import org.apache.ibatis.annotations.Mapper;
10 10  
  11 +import java.util.Collections;
11 12 import java.util.List;
12 13  
13 14 /**
... ... @@ -32,7 +33,7 @@ public interface ImChannelMessageMapper extends BaseMapperX<ImChannelMessageDO>
32 33 return selectList(new LambdaQueryWrapperX<ImChannelMessageDO>()
33 34 .gt(ImChannelMessageDO::getId, minId)
34 35 .and(w -> w.isNull(ImChannelMessageDO::getReceiverUserIds)
35   - .or().eq(ImChannelMessageDO::getReceiverUserIds, "")
  36 + .or().eq(ImChannelMessageDO::getReceiverUserIds, Collections.emptyList())
36 37 .or().apply(MyBatisUtils.findInSet("receiver_user_ids"), userId))
37 38 .orderByAsc(ImChannelMessageDO::getId)
38 39 .last("LIMIT " + size));
... ...
yudao-module-im/src/test/java/cn/iocoder/yudao/module/im/dal/mysql/message/ImChannelMessageMapperTest.java 0 → 100644
  View file @91f23df
  1 +package cn.iocoder.yudao.module.im.dal.mysql.message;
  2 +
  3 +import cn.iocoder.yudao.framework.test.core.ut.BaseDbUnitTest;
  4 +import cn.iocoder.yudao.module.im.dal.dataobject.message.ImChannelMessageDO;
  5 +import jakarta.annotation.Resource;
  6 +import org.junit.jupiter.api.Test;
  7 +import org.springframework.test.context.jdbc.Sql;
  8 +
  9 +import java.time.LocalDateTime;
  10 +import java.util.List;
  11 +
  12 +import static org.junit.jupiter.api.Assertions.assertEquals;
  13 +
  14 +@Sql(statements = "DELETE FROM im_channel_message", executionPhase = Sql.ExecutionPhase.AFTER_TEST_METHOD)
  15 +public class ImChannelMessageMapperTest extends BaseDbUnitTest {
  16 +
  17 + @Resource
  18 + private ImChannelMessageMapper mapper;
  19 +
  20 + @Test
  21 + public void testSelectListByUserAndMinId_includesBroadcastAndMatchingRecipients() {
  22 + ImChannelMessageDO nullRecipients = insertMessage(null);
  23 + ImChannelMessageDO emptyRecipients = insertMessage(List.of());
  24 + ImChannelMessageDO matchingRecipients = insertMessage(List.of(1L, 2L));
  25 + insertMessage(List.of(2L, 11L)); // 用户 1 不应误命中用户 11
  26 + ImChannelMessageDO deleted = insertMessage(List.of(1L));
  27 + mapper.deleteById(deleted.getId());
  28 +
  29 + List<ImChannelMessageDO> result = mapper.selectListByUserAndMinId(1L, 0L, 100);
  30 +
  31 + assertEquals(List.of(nullRecipients.getId(), emptyRecipients.getId(), matchingRecipients.getId()),
  32 + result.stream().map(ImChannelMessageDO::getId).toList());
  33 + }
  34 +
  35 + @Test
  36 + public void testSelectListByUserAndMinId_respectsCursorAndLimit() {
  37 + ImChannelMessageDO cursor = insertMessage(null);
  38 + ImChannelMessageDO next = insertMessage(List.of());
  39 + insertMessage(List.of(1L));
  40 +
  41 + List<ImChannelMessageDO> result = mapper.selectListByUserAndMinId(1L, cursor.getId(), 1);
  42 +
  43 + assertEquals(List.of(next.getId()), result.stream().map(ImChannelMessageDO::getId).toList());
  44 + }
  45 +
  46 + private ImChannelMessageDO insertMessage(List<Long> receiverUserIds) {
  47 + ImChannelMessageDO message = ImChannelMessageDO.builder()
  48 + .channelId(10L)
  49 + .materialId(20L)
  50 + .type(1)
  51 + .content("{}")
  52 + .receiverUserIds(receiverUserIds)
  53 + .sendTime(LocalDateTime.now())
  54 + .build();
  55 + mapper.insert(message);
  56 + return message;
  57 + }
  58 +
  59 +}
... ...