BJ_ZTEITS-Developers / parking-cloud-yudao

Commit 81666e3b6207e96bd4b7e7f35ad7a1ad8289adcb

Authored by YunaiV
1 parent a11dd1be

mall：code review 商品的添加和修改 VO；微调商品的 SPU/SKU 表

Inline Side-by-side
Showing 2 changed files with 4 additions and 6 deletions
yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/service/sku/ProductSkuServiceImpl.java
  View file @81666e3
... ... @@ -2,12 +2,10 @@ package cn.iocoder.yudao.module.product.service.sku;
2 2  
3 3 import cn.iocoder.yudao.framework.common.exception.util.ServiceExceptionUtil;
4 4 import cn.iocoder.yudao.framework.common.pojo.PageResult;
5   -import cn.iocoder.yudao.module.product.controller.admin.property.vo.ProductPropertyCreateReqVO;
6 5 import cn.iocoder.yudao.module.product.controller.admin.property.vo.ProductPropertyRespVO;
7   -import cn.iocoder.yudao.module.product.controller.admin.propertyvalue.vo.ProductPropertyValueCreateReqVO;
8 6 import cn.iocoder.yudao.module.product.controller.admin.propertyvalue.vo.ProductPropertyValueRespVO;
9 7 import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuBaseVO;
10   -import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuCreateReqVO;
  8 +import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuCreateOrUpdateReqVO;
11 9 import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuPageReqVO;
12 10 import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuUpdateReqVO;
13 11 import cn.iocoder.yudao.module.product.convert.sku.ProductSkuConvert;
... ... @@ -90,7 +88,7 @@ public class ProductSkuServiceImpl implements ProductSkuService {
90 88 }
91 89  
92 90 @Override
93   - public void validateSkus(List<ProductSkuCreateReqVO> list) {
  91 + public void validateSkus(List<ProductSkuCreateOrUpdateReqVO> list) {
94 92 List<ProductSkuBaseVO.Property> skuPropertyList = list.stream().flatMap(p -> Optional.of(p.getProperties()).orElse(new ArrayList<>()).stream()).collect(Collectors.toList());
95 93 // 校验规格属性以及规格值是否存在
96 94 List<Long> propertyIds = skuPropertyList.stream().map(ProductSkuBaseVO.Property::getPropertyId).collect(Collectors.toList());
... ...
yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/service/spu/ProductSpuServiceImpl.java
  View file @81666e3
... ... @@ -56,7 +56,7 @@ public class ProductSpuServiceImpl implements ProductSpuService {
56 56 // 校验分类
57 57 categoryService.validateProductCategory(createReqVO.getCategoryId());
58 58 // 校验SKU
59   - List<ProductSkuCreateReqVO> skuCreateReqList = createReqVO.getSkus();
  59 + List<ProductSkuCreateOrUpdateReqVO> skuCreateReqList = createReqVO.getSkus();
60 60 if(createReqVO.getSpecType() == 1) {
61 61 productSkuService.validateSkus(skuCreateReqList);
62 62 }
... ... @@ -78,7 +78,7 @@ public class ProductSpuServiceImpl implements ProductSpuService {
78 78 // 校验分类
79 79 categoryService.validateProductCategory(updateReqVO.getCategoryId());
80 80 // 校验SKU
81   - List<ProductSkuCreateReqVO> skuCreateReqList = updateReqVO.getSkus();
  81 + List<ProductSkuCreateOrUpdateReqVO> skuCreateReqList = updateReqVO.getSkus();
82 82 if(updateReqVO.getSpecType() == 1) {
83 83 productSkuService.validateSkus(skuCreateReqList);
84 84 }
... ...