【代码评审】BPM：删除表单数据触发器

YunaiV
1 parent b88c09f4
Showing 4 changed files with 9 additions and 9 deletions
yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/service/task/BpmProcessInstanceService.java
yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/service/task/BpmProcessInstanceServiceImpl.java
yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/service/task/trigger/BpmFormDeleteTrigger.java
yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/service/task/trigger/BpmFormUpdateTrigger.java
@@ -160,10 +160,10 @@ public interface BpmProcessInstanceService {
     /**
      * 删除 ProcessInstance 的变量
      *
-     * @param processInstanceId  流程编号
+     * @param id  流程编号
      * @param variableNames 流程变量名
      */
-    void removeProcessInstanceVariables(String processInstanceId, Collection<String> variableNames);
+    void removeProcessInstanceVariables(String id, Collection<String> variableNames);
     // ========== Event 事件相关方法 ==========
@@ -790,8 +790,8 @@ public class BpmProcessInstanceServiceImpl implements BpmProcessInstanceService 
     }
     @Override
-    public void removeProcessInstanceVariables(String processInstanceId, Collection<String> variableNames) {
-        runtimeService.removeVariables(processInstanceId, variableNames);
+    public void removeProcessInstanceVariables(String id, Collection<String> variableNames) {
+        runtimeService.removeVariables(id, variableNames);
     }
     // ========== Event 事件相关方法 ==========
@@ -43,10 +43,10 @@ public class BpmFormDeleteTrigger implements BpmTrigger {
             return;
         }
-        // 2.获取流程变量
+        // 2. 获取流程变量
         Map<String, Object> processVariables = processInstanceService.getProcessInstance(processInstanceId).getProcessVariables();
-        // 3.获取需要删除的表单字段
+        // 3.1 获取需要删除的表单字段
         Set<String> deleteFields = new HashSet<>();
         settings.forEach(setting -> {
             if (CollUtil.isEmpty(setting.getDeleteFields())) {
@@ -64,7 +64,7 @@ public class BpmFormDeleteTrigger implements BpmTrigger {
             }
         });
-        // 4. 删除流程变量
+        // 3.2 删除流程变量
         if (CollUtil.isNotEmpty(deleteFields)) {
             processInstanceService.removeProcessInstanceVariables(processInstanceId, deleteFields);
         }
@@ -41,10 +41,10 @@ public class BpmFormUpdateTrigger implements BpmTrigger {
             return;
         }
-        // 2.获取流程变量
+        // 2. 获取流程变量
         Map<String, Object> processVariables = processInstanceService.getProcessInstance(processInstanceId).getProcessVariables();
-        // 3.更新流程变量
+        // 3. 更新流程变量
         for (FormTriggerSetting setting : settings) {
             if (CollUtil.isEmpty(setting.getUpdateFormFields())) {
                 continue;