code review：商品 spu、sku 的逻辑

YunaiV
1 parent f07bf8b0
Showing 9 changed files with 74 additions and 57 deletions
yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/controller/admin/sku/ProductSkuController.java
yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/controller/admin/sku/vo/ProductSkuBaseVO.java
yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/controller/admin/spu/ProductSpuController.java
yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/controller/admin/spu/vo/ProductSpuCreateReqVO.java
yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/dal/dataobject/spu/ProductSpuDO.java
yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/service/category/CategoryService.java
yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/service/category/CategoryServiceImpl.java
yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/service/sku/ProductSkuService.java
yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/service/sku/ProductSkuServiceImpl.java
 package cn.iocoder.yudao.module.product.controller.admin.sku;
-import org.springframework.web.bind.annotation.*;
-import javax.annotation.Resource;
-import org.springframework.validation.annotation.Validated;
-import org.springframework.security.access.prepost.PreAuthorize;
-import io.swagger.annotations.*;
-
-import javax.validation.constraints.*;
-import javax.validation.*;
-import javax.servlet.http.*;
-import java.util.*;
-import java.io.IOException;
-
-import cn.iocoder.yudao.framework.common.pojo.PageResult;
 import cn.iocoder.yudao.framework.common.pojo.CommonResult;
-import static cn.iocoder.yudao.framework.common.pojo.CommonResult.success;
-
+import cn.iocoder.yudao.framework.common.pojo.PageResult;
 import cn.iocoder.yudao.framework.excel.core.util.ExcelUtils;
-
 import cn.iocoder.yudao.framework.operatelog.core.annotations.OperateLog;
-import static cn.iocoder.yudao.framework.operatelog.core.enums.OperateTypeEnum.*;
-
 import cn.iocoder.yudao.module.product.controller.admin.sku.vo.*;
-import cn.iocoder.yudao.module.product.dal.dataobject.sku.ProductSkuDO;
 import cn.iocoder.yudao.module.product.convert.sku.ProductSkuConvert;
+import cn.iocoder.yudao.module.product.dal.dataobject.sku.ProductSkuDO;
 import cn.iocoder.yudao.module.product.service.sku.ProductSkuService;
+import io.swagger.annotations.Api;
+import io.swagger.annotations.ApiImplicitParam;
+import io.swagger.annotations.ApiOperation;
+import org.springframework.security.access.prepost.PreAuthorize;
+import org.springframework.validation.annotation.Validated;
+import org.springframework.web.bind.annotation.*;
+
+import javax.annotation.Resource;
+import javax.servlet.http.HttpServletResponse;
+import javax.validation.Valid;
+import java.io.IOException;
+import java.util.Collection;
+import java.util.List;
+
+import static cn.iocoder.yudao.framework.common.pojo.CommonResult.success;
+import static cn.iocoder.yudao.framework.operatelog.core.enums.OperateTypeEnum.EXPORT;
+// TODO @franky：中英文之间要有空格哈。商品 sku
 @Api(tags = "管理后台 - 商品sku")
 @RestController
 @RequestMapping("/product/sku")
 package cn.iocoder.yudao.module.product.controller.admin.sku.vo;
-import lombok.*;
-import java.util.*;
-import io.swagger.annotations.*;
-import javax.validation.constraints.*;
+import io.swagger.annotations.ApiModelProperty;
+import lombok.Data;
+
+import javax.validation.constraints.NotNull;
+import java.util.List;
 /**
 * 商品sku Base VO，提供给添加、修改、详细的子 VO 使用
@@ -12,10 +13,14 @@ import javax.validation.constraints.*;
 @Data
 public class ProductSkuBaseVO {
+    // TODO @franky：example 要写哈；
+
     @ApiModelProperty(value = "spu编号", required = true)
     @NotNull(message = "spu编号不能为空")
     private Long spuId;
+    // TODO @franky：类似这种字段，有额外说明的。可以写成；    @ApiModelProperty(value = "规格值数组", required = true, notes = "json格式， [{propertyId: , valueId: }, {propertyId: , valueId: }]")
+
     @ApiModelProperty(value = "规格值数组-json格式， [{propertyId: , valueId: }, {propertyId: , valueId: }]", required = true)
     @NotNull(message = "规格值数组-json格式， [{propertyId: , valueId: }, {propertyId: , valueId: }]不能为空")
     private List<Property> properties;
@@ -43,12 +48,15 @@ public class ProductSkuBaseVO {
     @ApiModelProperty(value = "状态： 0-正常 1-禁用")
     private Integer status;
+    // TODO @franky 要有 swagger 注解
     @Data
     public static class Property {
+
         @NotNull(message = "规格属性名id不能为空")
         private Integer propertyId;
         @NotNull(message = "规格属性值id不能为空")
         private Integer valueId;
+
     }
 }
 package cn.iocoder.yudao.module.product.controller.admin.spu;
-import nonapi.io.github.classgraph.utils.LogNode;
-import org.springframework.web.bind.annotation.*;
-import javax.annotation.Resource;
-import org.springframework.validation.annotation.Validated;
-import org.springframework.security.access.prepost.PreAuthorize;
-import io.swagger.annotations.*;
-
-import javax.validation.constraints.*;
-import javax.validation.*;
-import javax.servlet.http.*;
-import java.util.*;
-import java.io.IOException;
-
-import cn.iocoder.yudao.framework.common.pojo.PageResult;
 import cn.iocoder.yudao.framework.common.pojo.CommonResult;
-import static cn.iocoder.yudao.framework.common.pojo.CommonResult.success;
-
+import cn.iocoder.yudao.framework.common.pojo.PageResult;
 import cn.iocoder.yudao.framework.excel.core.util.ExcelUtils;
-
 import cn.iocoder.yudao.framework.operatelog.core.annotations.OperateLog;
-import static cn.iocoder.yudao.framework.operatelog.core.enums.OperateTypeEnum.*;
-
 import cn.iocoder.yudao.module.product.controller.admin.spu.vo.*;
-import cn.iocoder.yudao.module.product.dal.dataobject.spu.ProductSpuDO;
 import cn.iocoder.yudao.module.product.convert.spu.ProductSpuConvert;
+import cn.iocoder.yudao.module.product.dal.dataobject.spu.ProductSpuDO;
 import cn.iocoder.yudao.module.product.service.spu.ProductSpuService;
+import io.swagger.annotations.Api;
+import io.swagger.annotations.ApiImplicitParam;
+import io.swagger.annotations.ApiOperation;
+import org.springframework.security.access.prepost.PreAuthorize;
+import org.springframework.validation.annotation.Validated;
+import org.springframework.web.bind.annotation.*;
+
+import javax.annotation.Resource;
+import javax.servlet.http.HttpServletResponse;
+import javax.validation.Valid;
+import java.io.IOException;
+import java.util.Collection;
+import java.util.List;
+
+import static cn.iocoder.yudao.framework.common.pojo.CommonResult.success;
+import static cn.iocoder.yudao.framework.operatelog.core.enums.OperateTypeEnum.EXPORT;
 @Api(tags = "管理后台 - 商品spu")
 @RestController
@@ -43,6 +41,7 @@ public class ProductSpuController {
         return success(spuService.createSpu(createReqVO));
     }
+    // TODO @franky：SpuUpdateReqVO 缺少前缀
     @PutMapping("/update")
     @ApiOperation("更新商品spu")
     @PreAuthorize("@ss.hasPermission('product:spu:update')")
 package cn.iocoder.yudao.module.product.controller.admin.spu.vo;
 import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuCreateReqVO;
-import lombok.*;
-import java.util.*;
-import io.swagger.annotations.*;
+import io.swagger.annotations.ApiModel;
+import io.swagger.annotations.ApiModelProperty;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+import lombok.ToString;
 import javax.validation.Valid;
-import javax.validation.constraints.*;
+import java.util.List;
 @ApiModel("管理后台 - 商品spu创建 Request VO")
 @Data
@@ -14,6 +16,7 @@ import javax.validation.constraints.*;
 @ToString(callSuper = true)
 public class ProductSpuCreateReqVO extends ProductSpuBaseVO {
+    // TODO @franky：这种可以缩写下，skus
     @ApiModelProperty(value = "sku组合")
     @Valid
     List<ProductSkuCreateReqVO> productSkuCreateReqVOS;
 package cn.iocoder.yudao.module.product.dal.dataobject.spu;
-import cn.hutool.log.Log;
 import cn.iocoder.yudao.framework.mybatis.core.dataobject.BaseDO;
 import com.baomidou.mybatisplus.annotation.KeySequence;
 import com.baomidou.mybatisplus.annotation.TableId;
 import com.baomidou.mybatisplus.annotation.TableName;
 import lombok.*;
-import java.util.List;
-
 /**
  * 商品spu DO
  *
@@ -48,7 +45,7 @@ public class ProductSpuDO extends BaseDO {
     /**
      * 商品主图地址,* 数组，以逗号分隔,最多上传15张
      */
-    // TODO franky：List<String>
+    // TODO franky：List<String>。可以参考别的模块，怎么处理这种类型的哈
     private String picUrls;
     /**
      * 排序字段
@@ -8,6 +8,7 @@ import javax.validation.Valid;
 import java.util.Collection;
 import java.util.List;
+// TODO @JeromeSoar：需要 Product 前缀
 /**
  * 商品分类 Service 接口
  *
@@ -65,6 +65,7 @@ public class CategoryServiceImpl implements CategoryService {
     }
     private CategoryDO validateCategoryExists(Long id, ErrorCode errorCode) {
+        // TODO franky：0 要枚举哈
         if (id == 0) {
             return new CategoryDO().setId(id);
         }
 package cn.iocoder.yudao.module.product.service.sku;
-import java.util.*;
-import javax.validation.*;
-import cn.iocoder.yudao.module.product.controller.admin.sku.vo.*;
-import cn.iocoder.yudao.module.product.dal.dataobject.sku.ProductSkuDO;
 import cn.iocoder.yudao.framework.common.pojo.PageResult;
+import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuCreateReqVO;
+import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuExportReqVO;
+import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuPageReqVO;
+import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuUpdateReqVO;
+import cn.iocoder.yudao.module.product.dal.dataobject.sku.ProductSkuDO;
+
+import javax.validation.Valid;
+import java.util.Collection;
+import java.util.List;
 /**
  * 商品sku Service 接口
@@ -67,8 +72,10 @@ public interface ProductSkuService {
      */
     List<ProductSkuDO> getSkuList(ProductSkuExportReqVO exportReqVO);
+    // TODO @franky：validateSkus;skuCreateReqList => list
     /**
-     *对sku的组合的属性等进行合法性校验
+     * 对 sku 的组合的属性等进行合法性校验
+     *
      * @param skuCreateReqList sku组合的集合
      */
     void validatedSkuReq(List<ProductSkuCreateReqVO> skuCreateReqList);
@@ -76,7 +83,7 @@ public interface ProductSkuService {
     /**
      * 批量保存sku
      * @param skuDOList sku对象集合
-     * @return
+     * @return // TODO @franky：这里的 return 可以去掉；方法名可以改成 createSkus(list)
      */
     void batchSave(List<ProductSkuDO> skuDOList);
 }
@@ -88,6 +88,7 @@ public class ProductSkuServiceImpl implements ProductSkuService {
         return productSkuMapper.selectList(exportReqVO);
     }
+    // TODO @franky：这个方法，貌似实现的还是有点问题哈。例如说，throw 异常，后面还执行逻辑~
     @Override
     public void validatedSkuReq(List<ProductSkuCreateReqVO> skuCreateReqList) {
         List<ProductSkuBaseVO.Property> skuPropertyList = skuCreateReqList.stream().flatMap(p -> p.getProperties().stream()).collect(Collectors.toList());