Commit 67173a4f2fa4b0810fc54c8a61b1c5e2a249329d

Authored by YunaiV
1 parent d20a5f54

✨ feat(mes): 更新反馈和入库相关接口及状态管理

将多个接口的执行方法重命名为完成方法,增强语义清晰度。更新相关的权限控制和状态枚举,确保系统逻辑一致性。
Showing 23 changed files with 39 additions and 39 deletions
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/controller/admin/pro/feedback/MesProFeedbackController.java
@@ -154,12 +154,12 @@ public class MesProFeedbackController { @@ -154,12 +154,12 @@ public class MesProFeedbackController {
154 return success(true); 154 return success(true);
155 } 155 }
156 156
157 - @PutMapping("/execute") 157 + @PutMapping("/finish")
158 @Operation(summary = "执行报工") 158 @Operation(summary = "执行报工")
159 @Parameter(name = "id", description = "编号", required = true) 159 @Parameter(name = "id", description = "编号", required = true)
160 - @PreAuthorize("@ss.hasPermission('mes:pro-feedback:update')")  
161 - public CommonResult<Boolean> executeFeedback(@RequestParam("id") Long id) {  
162 - feedbackService.executeFeedback(id); 160 + @PreAuthorize("@ss.hasPermission('mes:pro-feedback:finish')")
  161 + public CommonResult<Boolean> finishFeedback(@RequestParam("id") Long id) {
  162 + feedbackService.finishFeedback(id);
163 return success(true); 163 return success(true);
164 } 164 }
165 165
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/controller/admin/wm/itemreceipt/MesWmItemReceiptController.java
@@ -137,12 +137,12 @@ public class MesWmItemReceiptController { @@ -137,12 +137,12 @@ public class MesWmItemReceiptController {
137 return success(true); 137 return success(true);
138 } 138 }
139 139
140 - @PutMapping("/execute") 140 + @PutMapping("/finish")
141 @Operation(summary = "执行入库") 141 @Operation(summary = "执行入库")
142 @Parameter(name = "id", description = "编号", required = true) 142 @Parameter(name = "id", description = "编号", required = true)
143 - @PreAuthorize("@ss.hasPermission('mes:wm-item-receipt:execute')")  
144 - public CommonResult<Boolean> executeItemReceipt(@RequestParam("id") Long id) {  
145 - itemReceiptService.executeItemReceipt(id); 143 + @PreAuthorize("@ss.hasPermission('mes:wm-item-receipt:finish')")
  144 + public CommonResult<Boolean> finishItemReceipt(@RequestParam("id") Long id) {
  145 + itemReceiptService.finishItemReceipt(id);
146 return success(true); 146 return success(true);
147 } 147 }
148 148
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/controller/admin/wm/productionissue/MesWmProductionIssueController.java
@@ -109,7 +109,7 @@ public class MesWmProductionIssueController { @@ -109,7 +109,7 @@ public class MesWmProductionIssueController {
109 @PutMapping("/finish") 109 @PutMapping("/finish")
110 @Operation(summary = "完成领料出库单") 110 @Operation(summary = "完成领料出库单")
111 @Parameter(name = "id", description = "编号", required = true) 111 @Parameter(name = "id", description = "编号", required = true)
112 - @PreAuthorize("@ss.hasPermission('mes:wm-production-issue:execute')") 112 + @PreAuthorize("@ss.hasPermission('mes:wm-production-issue:finish')")
113 public CommonResult<Boolean> finishProductionIssue(@RequestParam("id") Long id) { 113 public CommonResult<Boolean> finishProductionIssue(@RequestParam("id") Long id) {
114 issueService.finishProductionIssue(id); 114 issueService.finishProductionIssue(id);
115 return success(true); 115 return success(true);
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/controller/admin/wm/productreceipt/MesWmProductReceiptController.java
@@ -131,12 +131,12 @@ public class MesWmProductReceiptController { @@ -131,12 +131,12 @@ public class MesWmProductReceiptController {
131 return success(true); 131 return success(true);
132 } 132 }
133 133
134 - @PutMapping("/execute") 134 + @PutMapping("/finish")
135 @Operation(summary = "执行入库") 135 @Operation(summary = "执行入库")
136 @Parameter(name = "id", description = "编号", required = true) 136 @Parameter(name = "id", description = "编号", required = true)
137 - @PreAuthorize("@ss.hasPermission('mes:wm-product-receipt:execute')")  
138 - public CommonResult<Boolean> executeProductReceipt(@RequestParam("id") Long id) {  
139 - productReceiptService.executeProductReceipt(id); 137 + @PreAuthorize("@ss.hasPermission('mes:wm-product-receipt:finish')")
  138 + public CommonResult<Boolean> finishProductReceipt(@RequestParam("id") Long id) {
  139 + productReceiptService.finishProductReceipt(id);
140 return success(true); 140 return success(true);
141 } 141 }
142 142
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/controller/admin/wm/productsales/MesWmProductSalesController.java
@@ -138,12 +138,12 @@ public class MesWmProductSalesController { @@ -138,12 +138,12 @@ public class MesWmProductSalesController {
138 return success(true); 138 return success(true);
139 } 139 }
140 140
141 - @PutMapping("/execute") 141 + @PutMapping("/finish")
142 @Operation(summary = "执行出库") 142 @Operation(summary = "执行出库")
143 @Parameter(name = "id", description = "编号", required = true) 143 @Parameter(name = "id", description = "编号", required = true)
144 - @PreAuthorize("@ss.hasPermission('mes:wm-product-sales:execute')")  
145 - public CommonResult<Boolean> executeProductSales(@RequestParam("id") Long id) {  
146 - productSalesService.executeProductSales(id); 144 + @PreAuthorize("@ss.hasPermission('mes:wm-product-sales:finish')")
  145 + public CommonResult<Boolean> finishProductSales(@RequestParam("id") Long id) {
  146 + productSalesService.finishProductSales(id);
147 return success(true); 147 return success(true);
148 } 148 }
149 149
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/controller/admin/wm/returnissue/MesWmReturnIssueController.java
@@ -109,7 +109,7 @@ public class MesWmReturnIssueController { @@ -109,7 +109,7 @@ public class MesWmReturnIssueController {
109 @PutMapping("/finish") 109 @PutMapping("/finish")
110 @Operation(summary = "完成生产退料单") 110 @Operation(summary = "完成生产退料单")
111 @Parameter(name = "id", description = "编号", required = true) 111 @Parameter(name = "id", description = "编号", required = true)
112 - @PreAuthorize("@ss.hasPermission('mes:wm-return-issue:execute')") 112 + @PreAuthorize("@ss.hasPermission('mes:wm-return-issue:finish')")
113 public CommonResult<Boolean> finishReturnIssue(@RequestParam("id") Long id) { 113 public CommonResult<Boolean> finishReturnIssue(@RequestParam("id") Long id) {
114 issueService.finishReturnIssue(id); 114 issueService.finishReturnIssue(id);
115 return success(true); 115 return success(true);
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/controller/admin/wm/returnsales/MesWmReturnSalesController.java
@@ -116,12 +116,12 @@ public class MesWmReturnSalesController { @@ -116,12 +116,12 @@ public class MesWmReturnSalesController {
116 return success(true); 116 return success(true);
117 } 117 }
118 118
119 - @PutMapping("/execute") 119 + @PutMapping("/finish")
120 @Operation(summary = "执行退货") 120 @Operation(summary = "执行退货")
121 @Parameter(name = "id", description = "编号", required = true) 121 @Parameter(name = "id", description = "编号", required = true)
122 - @PreAuthorize("@ss.hasPermission('mes:wm-return-sales:execute')")  
123 - public CommonResult<Boolean> executeReturnSales(@RequestParam("id") Long id) {  
124 - returnSalesService.executeReturnSales(id); 122 + @PreAuthorize("@ss.hasPermission('mes:wm-return-sales:finish')")
  123 + public CommonResult<Boolean> finishReturnSales(@RequestParam("id") Long id) {
  124 + returnSalesService.finishReturnSales(id);
125 return success(true); 125 return success(true);
126 } 126 }
127 127
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/controller/admin/wm/returnvendor/MesWmReturnVendorController.java
@@ -123,7 +123,7 @@ public class MesWmReturnVendorController { @@ -123,7 +123,7 @@ public class MesWmReturnVendorController {
123 @PutMapping("/finish") 123 @PutMapping("/finish")
124 @Operation(summary = "完成供应商退货单") 124 @Operation(summary = "完成供应商退货单")
125 @Parameter(name = "id", description = "编号", required = true) 125 @Parameter(name = "id", description = "编号", required = true)
126 - @PreAuthorize("@ss.hasPermission('mes:wm-return-vendor:execute')") 126 + @PreAuthorize("@ss.hasPermission('mes:wm-return-vendor:finish')")
127 public CommonResult<Boolean> finishReturnVendor(@RequestParam("id") Long id) { 127 public CommonResult<Boolean> finishReturnVendor(@RequestParam("id") Long id) {
128 returnVendorService.finishReturnVendor(id); 128 returnVendorService.finishReturnVendor(id);
129 return success(true); 129 return success(true);
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/enums/ErrorCodeConstants.java
@@ -434,7 +434,7 @@ public interface ErrorCodeConstants { @@ -434,7 +434,7 @@ public interface ErrorCodeConstants {
434 ErrorCode WM_PRODUCT_SALES_CANNOT_SUBMIT = new ErrorCode(1_040_714_004, "当前状态不允许提交"); 434 ErrorCode WM_PRODUCT_SALES_CANNOT_SUBMIT = new ErrorCode(1_040_714_004, "当前状态不允许提交");
435 ErrorCode WM_PRODUCT_SALES_CANNOT_PICK = new ErrorCode(1_040_714_005, "当前状态不允许拣货"); 435 ErrorCode WM_PRODUCT_SALES_CANNOT_PICK = new ErrorCode(1_040_714_005, "当前状态不允许拣货");
436 ErrorCode WM_PRODUCT_SALES_CANNOT_SHIPPING = new ErrorCode(1_040_714_006, "当前状态不允许填写运单"); 436 ErrorCode WM_PRODUCT_SALES_CANNOT_SHIPPING = new ErrorCode(1_040_714_006, "当前状态不允许填写运单");
437 - ErrorCode WM_PRODUCT_SALES_CANNOT_EXECUTE = new ErrorCode(1_040_714_007, "当前状态不允许执行出库"); 437 + ErrorCode WM_PRODUCT_SALES_CANNOT_FINISH = new ErrorCode(1_040_714_007, "当前状态不允许执行出库");
438 ErrorCode WM_PRODUCT_SALES_CANNOT_CANCEL = new ErrorCode(1_040_714_008, "当前状态不允许取消"); 438 ErrorCode WM_PRODUCT_SALES_CANNOT_CANCEL = new ErrorCode(1_040_714_008, "当前状态不允许取消");
439 ErrorCode WM_PRODUCT_SALES_DETAILS_EMPTY = new ErrorCode(1_040_714_009, "拣货明细不能为空"); 439 ErrorCode WM_PRODUCT_SALES_DETAILS_EMPTY = new ErrorCode(1_040_714_009, "拣货明细不能为空");
440 ErrorCode WM_PRODUCT_SALES_DETAIL_QUANTITY_MISMATCH = new ErrorCode(1_040_714_010, "拣货数量与出库数量不匹配"); 440 ErrorCode WM_PRODUCT_SALES_DETAIL_QUANTITY_MISMATCH = new ErrorCode(1_040_714_010, "拣货数量与出库数量不匹配");
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/enums/wm/MesWmItemReceiptStatusEnum.java
@@ -39,7 +39,7 @@ public enum MesWmItemReceiptStatusEnum implements ArrayValuable&lt;Integer&gt; { @@ -39,7 +39,7 @@ public enum MesWmItemReceiptStatusEnum implements ArrayValuable&lt;Integer&gt; {
39 /** 39 /**
40 * 已完成 40 * 已完成
41 * 41 *
42 - * 对应方法:{@link MesWmItemReceiptService#executeItemReceipt(Long)} 42 + * 对应方法:{@link MesWmItemReceiptService#finishItemReceipt(Long)}
43 */ 43 */
44 FINISHED(MesOrderStatusConstants.FINISHED, "已完成"), 44 FINISHED(MesOrderStatusConstants.FINISHED, "已完成"),
45 /** 45 /**
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/enums/wm/MesWmProductReceiptStatusEnum.java
@@ -39,7 +39,7 @@ public enum MesWmProductReceiptStatusEnum implements ArrayValuable&lt;Integer&gt; { @@ -39,7 +39,7 @@ public enum MesWmProductReceiptStatusEnum implements ArrayValuable&lt;Integer&gt; {
39 /** 39 /**
40 * 已完成 40 * 已完成
41 * 41 *
42 - * 对应方法:{@link MesWmProductReceiptService#executeProductReceipt(Long)} 42 + * 对应方法:{@link MesWmProductReceiptService#finishProductReceipt(Long)}
43 */ 43 */
44 FINISHED(MesOrderStatusConstants.FINISHED, "已完成"), 44 FINISHED(MesOrderStatusConstants.FINISHED, "已完成"),
45 /** 45 /**
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/enums/wm/MesWmProductSalesStatusEnum.java
@@ -48,7 +48,7 @@ public enum MesWmProductSalesStatusEnum implements ArrayValuable&lt;Integer&gt; { @@ -48,7 +48,7 @@ public enum MesWmProductSalesStatusEnum implements ArrayValuable&lt;Integer&gt; {
48 /** 48 /**
49 * 已完成 49 * 已完成
50 * 50 *
51 - * 对应方法:{@link MesWmProductSalesService#executeProductSales(Long)} 51 + * 对应方法:{@link MesWmProductSalesService#finishProductSales(Long)}
52 */ 52 */
53 FINISHED(MesOrderStatusConstants.FINISHED, "已完成"), 53 FINISHED(MesOrderStatusConstants.FINISHED, "已完成"),
54 /** 54 /**
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/enums/wm/MesWmReturnSalesStatusEnum.java
@@ -31,7 +31,7 @@ public enum MesWmReturnSalesStatusEnum implements ArrayValuable&lt;Integer&gt; { @@ -31,7 +31,7 @@ public enum MesWmReturnSalesStatusEnum implements ArrayValuable&lt;Integer&gt; {
31 /** 31 /**
32 * 待上架 32 * 待上架
33 * 33 *
34 - * 对应方法:{@link cn.iocoder.yudao.module.mes.service.wm.returnsales.MesWmReturnSalesService#executeReturnSales} 34 + * 对应方法:{@link cn.iocoder.yudao.module.mes.service.wm.returnsales.MesWmReturnSalesService#finishReturnSales}
35 */ 35 */
36 APPROVED(MesOrderStatusConstants.APPROVED, "待上架"), 36 APPROVED(MesOrderStatusConstants.APPROVED, "待上架"),
37 /** 37 /**
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/pro/feedback/MesProFeedbackService.java
@@ -70,7 +70,7 @@ public interface MesProFeedbackService { @@ -70,7 +70,7 @@ public interface MesProFeedbackService {
70 * 70 *
71 * @param id 编号 71 * @param id 编号
72 */ 72 */
73 - void executeFeedback(Long id); 73 + void finishFeedback(Long id);
74 74
75 /** 75 /**
76 * 取消报工 76 * 取消报工
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/pro/feedback/MesProFeedbackServiceImpl.java
@@ -108,7 +108,7 @@ public class MesProFeedbackServiceImpl implements MesProFeedbackService { @@ -108,7 +108,7 @@ public class MesProFeedbackServiceImpl implements MesProFeedbackService {
108 108
109 @Override 109 @Override
110 @Transactional(rollbackFor = Exception.class) 110 @Transactional(rollbackFor = Exception.class)
111 - public void executeFeedback(Long id) { 111 + public void finishFeedback(Long id) {
112 // 1. 校验存在 + 审批中状态 112 // 1. 校验存在 + 审批中状态
113 MesProFeedbackDO feedback = validateFeedbackStatusApproving(id); 113 MesProFeedbackDO feedback = validateFeedbackStatusApproving(id);
114 114
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/itemreceipt/MesWmItemReceiptService.java
@@ -68,7 +68,7 @@ public interface MesWmItemReceiptService { @@ -68,7 +68,7 @@ public interface MesWmItemReceiptService {
68 * 68 *
69 * @param id 编号 69 * @param id 编号
70 */ 70 */
71 - void executeItemReceipt(Long id); 71 + void finishItemReceipt(Long id);
72 72
73 /** 73 /**
74 * 取消采购入库单(任意非已完成/已取消状态 → 已取消) 74 * 取消采购入库单(任意非已完成/已取消状态 → 已取消)
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/itemreceipt/MesWmItemReceiptServiceImpl.java
@@ -139,7 +139,7 @@ public class MesWmItemReceiptServiceImpl implements MesWmItemReceiptService { @@ -139,7 +139,7 @@ public class MesWmItemReceiptServiceImpl implements MesWmItemReceiptService {
139 139
140 @Override 140 @Override
141 @Transactional(rollbackFor = Exception.class) 141 @Transactional(rollbackFor = Exception.class)
142 - public void executeItemReceipt(Long id) { 142 + public void finishItemReceipt(Long id) {
143 // 校验存在 143 // 校验存在
144 MesWmItemReceiptDO receipt = validateItemReceiptExists(id); 144 MesWmItemReceiptDO receipt = validateItemReceiptExists(id);
145 if (ObjUtil.notEqual(MesWmItemReceiptStatusEnum.APPROVED.getStatus(), receipt.getStatus())) { 145 if (ObjUtil.notEqual(MesWmItemReceiptStatusEnum.APPROVED.getStatus(), receipt.getStatus())) {
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/productreceipt/MesWmProductReceiptService.java
@@ -68,7 +68,7 @@ public interface MesWmProductReceiptService { @@ -68,7 +68,7 @@ public interface MesWmProductReceiptService {
68 * 68 *
69 * @param id 编号 69 * @param id 编号
70 */ 70 */
71 - void executeProductReceipt(Long id); 71 + void finishProductReceipt(Long id);
72 72
73 /** 73 /**
74 * 取消产品收货单(任意非已完成/已取消状态 → 已取消) 74 * 取消产品收货单(任意非已完成/已取消状态 → 已取消)
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/productreceipt/MesWmProductReceiptServiceImpl.java
@@ -153,7 +153,7 @@ public class MesWmProductReceiptServiceImpl implements MesWmProductReceiptServic @@ -153,7 +153,7 @@ public class MesWmProductReceiptServiceImpl implements MesWmProductReceiptServic
153 153
154 @Override 154 @Override
155 @Transactional(rollbackFor = Exception.class) 155 @Transactional(rollbackFor = Exception.class)
156 - public void executeProductReceipt(Long id) { 156 + public void finishProductReceipt(Long id) {
157 // 校验存在 157 // 校验存在
158 MesWmProductReceiptDO receipt = validateProductReceiptExists(id); 158 MesWmProductReceiptDO receipt = validateProductReceiptExists(id);
159 if (ObjUtil.notEqual(MesWmProductReceiptStatusEnum.APPROVED.getStatus(), receipt.getStatus())) { 159 if (ObjUtil.notEqual(MesWmProductReceiptStatusEnum.APPROVED.getStatus(), receipt.getStatus())) {
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/productsales/MesWmProductSalesService.java
@@ -86,7 +86,7 @@ public interface MesWmProductSalesService { @@ -86,7 +86,7 @@ public interface MesWmProductSalesService {
86 * 86 *
87 * @param id 编号 87 * @param id 编号
88 */ 88 */
89 - void executeProductSales(Long id); 89 + void finishProductSales(Long id);
90 90
91 /** 91 /**
92 * 取消销售出库单(任意非已完成/已取消状态 → 已取消) 92 * 取消销售出库单(任意非已完成/已取消状态 → 已取消)
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/productsales/MesWmProductSalesServiceImpl.java
@@ -169,11 +169,11 @@ public class MesWmProductSalesServiceImpl implements MesWmProductSalesService { @@ -169,11 +169,11 @@ public class MesWmProductSalesServiceImpl implements MesWmProductSalesService {
169 169
170 @Override 170 @Override
171 @Transactional(rollbackFor = Exception.class) 171 @Transactional(rollbackFor = Exception.class)
172 - public void executeProductSales(Long id) { 172 + public void finishProductSales(Long id) {
173 // 校验存在 173 // 校验存在
174 MesWmProductSalesDO sales = validateProductSalesExists(id); 174 MesWmProductSalesDO sales = validateProductSalesExists(id);
175 if (ObjUtil.notEqual(MesWmProductSalesStatusEnum.APPROVED.getStatus(), sales.getStatus())) { 175 if (ObjUtil.notEqual(MesWmProductSalesStatusEnum.APPROVED.getStatus(), sales.getStatus())) {
176 - throw exception(WM_PRODUCT_SALES_CANNOT_EXECUTE); 176 + throw exception(WM_PRODUCT_SALES_CANNOT_FINISH);
177 } 177 }
178 178
179 // 遍历所有明细,扣减库存 179 // 遍历所有明细,扣减库存
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/returnsales/MesWmReturnSalesService.java
@@ -71,7 +71,7 @@ public interface MesWmReturnSalesService { @@ -71,7 +71,7 @@ public interface MesWmReturnSalesService {
71 * 71 *
72 * @param id 编号 72 * @param id 编号
73 */ 73 */
74 - void executeReturnSales(Long id); 74 + void finishReturnSales(Long id);
75 75
76 /** 76 /**
77 * 执行上架(待上架 -> 已完成),更新库存台账 77 * 执行上架(待上架 -> 已完成),更新库存台账
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/returnsales/MesWmReturnSalesServiceImpl.java
@@ -122,7 +122,7 @@ public class MesWmReturnSalesServiceImpl implements MesWmReturnSalesService { @@ -122,7 +122,7 @@ public class MesWmReturnSalesServiceImpl implements MesWmReturnSalesService {
122 122
123 @Override 123 @Override
124 @Transactional(rollbackFor = Exception.class) 124 @Transactional(rollbackFor = Exception.class)
125 - public void executeReturnSales(Long id) { 125 + public void finishReturnSales(Long id) {
126 // 校验存在 126 // 校验存在
127 MesWmReturnSalesDO returnSales = validateReturnSalesExists(id); 127 MesWmReturnSalesDO returnSales = validateReturnSalesExists(id);
128 if (ObjUtil.notEqual(MesWmReturnSalesStatusEnum.APPROVING.getStatus(), returnSales.getStatus())) { 128 if (ObjUtil.notEqual(MesWmReturnSalesStatusEnum.APPROVING.getStatus(), returnSales.getStatus())) {