Commit 3cf0708f64c0110d95eec78a0c56e031c466fb32
1 parent
8a3264cf
review: 代码审查,方法抽取
Showing
1 changed file
with
2 additions
and
2 deletions
yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/service/task/BpmTaskServiceImpl.java
| @@ -581,11 +581,11 @@ public class BpmTaskServiceImpl implements BpmTaskService { | @@ -581,11 +581,11 @@ public class BpmTaskServiceImpl implements BpmTaskService { | ||
| 581 | List<Long> startUserSelectAssignee = startUserSelectAssignees.get(nextFlowNode.getId()); | 581 | List<Long> startUserSelectAssignee = startUserSelectAssignees.get(nextFlowNode.getId()); |
| 582 | // 3.3 如果节点中的审批人策略为 发起人自选,并且该节点的审批人为空 | 582 | // 3.3 如果节点中的审批人策略为 发起人自选,并且该节点的审批人为空 |
| 583 | if (ObjUtil.equals(candidateStrategy, BpmTaskCandidateStrategyEnum.START_USER_SELECT.getStrategy()) && CollUtil.isEmpty(startUserSelectAssignee)) { | 583 | if (ObjUtil.equals(candidateStrategy, BpmTaskCandidateStrategyEnum.START_USER_SELECT.getStrategy()) && CollUtil.isEmpty(startUserSelectAssignee)) { |
| 584 | - // 判断节点是否为执行节点 | 584 | + // 判断节点是否为执行节点,仅校验节点 |
| 585 | if (!nextAssignees.containsKey(nextFlowNode.getId())) { | 585 | if (!nextAssignees.containsKey(nextFlowNode.getId())) { |
| 586 | throw exception(TASK_TARGET_NODE_NOT_EXISTS, nextFlowNode.getName()); | 586 | throw exception(TASK_TARGET_NODE_NOT_EXISTS, nextFlowNode.getName()); |
| 587 | } | 587 | } |
| 588 | - // 判断节点的审批人是否配置 | 588 | + // 判断节点的审批人是否配置,节点存在,但未配置审批人 |
| 589 | if (CollUtil.isEmpty(nextAssignees.get(nextFlowNode.getId()))) { | 589 | if (CollUtil.isEmpty(nextAssignees.get(nextFlowNode.getId()))) { |
| 590 | throw exception(PROCESS_INSTANCE_APPROVE_USER_SELECT_ASSIGNEES_NOT_CONFIG, nextFlowNode.getName()); | 590 | throw exception(PROCESS_INSTANCE_APPROVE_USER_SELECT_ASSIGNEES_NOT_CONFIG, nextFlowNode.getName()); |
| 591 | } | 591 | } |