BJ_ZTEITS-Developers / parking-cloud-yudao

Commit 39ae547b9d9730e9dcd9960a7a426bf87fc44b15

Authored by YunaiV
1 parent 180a6269

📖 CRM：code review 线索逻辑

Inline Side-by-side
Showing 1 changed file with 7 additions and 11 deletions
yudao-module-crm/yudao-module-crm-biz/src/main/java/cn/iocoder/yudao/module/crm/service/clue/CrmClueServiceImpl.java
  View file @39ae547
... ... @@ -69,7 +69,6 @@ public class CrmClueServiceImpl implements CrmClueService {
69 69 @Transactional(rollbackFor = Exception.class)
70 70 @LogRecord(type = CRM_LEADS_TYPE, subType = CRM_LEADS_CREATE_SUB_TYPE, bizNo = "{{#clue.id}}",
71 71 success = CRM_LEADS_CREATE_SUCCESS)
72   - // TODO @min：补充相关几个方法的操作日志；
73 72 public Long createClue(CrmClueSaveReqVO createReqVO) {
74 73 // 1. 校验关联数据
75 74 validateRelationDataExists(createReqVO);
... ... @@ -111,7 +110,6 @@ public class CrmClueServiceImpl implements CrmClueService {
111 110 // 3. 记录操作日志上下文
112 111 LogRecordContext.putVariable(DiffParseFunction.OLD_OBJECT, BeanUtils.toBean(oldClue, CrmCustomerSaveReqVO.class));
113 112 LogRecordContext.putVariable("clueName", oldClue.getName());
114   -
115 113 }
116 114  
117 115 @Override
... ... @@ -189,23 +187,21 @@ public class CrmClueServiceImpl implements CrmClueService {
189 187 throw exception(CLUE_ANY_CLUE_NOT_EXISTS, StrUtil.join(",", clueIds));
190 188 }
191 189  
192   - // 过滤出未转化的客户
193   - List<CrmClueDO> unTransformClues = CollectionUtils.filterList(clues,
194   - clue -> ObjectUtil.notEqual(Boolean.TRUE, clue.getTransformStatus()));
195 190 // 存在已经转化的，直接提示哈。避免操作的用户，以为都转化成功了
196   - if (ObjectUtil.notEqual(clues.size(), unTransformClues.size())) {
197   - clueIds.removeAll(convertSet(unTransformClues, CrmClueDO::getId));
198   - throw exception(CLUE_ANY_CLUE_ALREADY_TRANSLATED, StrUtil.join(",", clueIds));
  191 + List<CrmClueDO> translatedClues = CollectionUtils.filterList(clues,
  192 + clue -> ObjectUtil.equal(Boolean.TRUE, clue.getTransformStatus()));
  193 + if (CollUtil.isNotEmpty(translatedClues)) {
  194 + throw exception(CLUE_ANY_CLUE_ALREADY_TRANSLATED, StrUtil.join(",", convertSet(translatedClues, CrmClueDO::getId)));
199 195 }
200 196  
201 197 // 遍历线索(未转化的线索)，创建对应的客户
202   - unTransformClues.forEach(clue -> {
  198 + reqVO.getIds().forEach(id -> {
203 199 // 1. 创建客户
204   - CrmCustomerSaveReqVO customerSaveReqVO = BeanUtils.toBean(clue, CrmCustomerSaveReqVO.class).setId(null);
  200 + CrmCustomerSaveReqVO customerSaveReqVO = BeanUtils.toBean(id, CrmCustomerSaveReqVO.class).setId(null);
205 201 Long customerId = customerService.createCustomer(customerSaveReqVO, userId);
206 202 // TODO @puhui999：如果有跟进记录，需要一起转过去；提问：艿艿这里是复制线索所有的跟进吗？还是直接把线索相关的跟进 bizType、bizId 全改为关联客户？
207 203 // 2. 更新线索
208   - clueMapper.updateById(new CrmClueDO().setId(clue.getId())
  204 + clueMapper.updateById(new CrmClueDO().setId(id)
209 205 .setTransformStatus(Boolean.TRUE).setCustomerId(customerId));
210 206 });
211 207 }
... ...