Commit 2cb726449e27a3efc6522eabe2a43679f6564bbc
1 parent
120736e3
perf: [BPM 工作流] 驳回预测 review 修改
Showing
1 changed file
with
5 additions
and
2 deletions
yudao-module-bpm/src/main/java/cn/iocoder/yudao/module/bpm/service/task/BpmProcessInstanceServiceImpl.java
| ... | ... | @@ -233,8 +233,11 @@ public class BpmProcessInstanceServiceImpl implements BpmProcessInstanceService |
| 233 | 233 | needSimulateTaskDefKeysByReturn.add(StrUtil.removePrefix(key, PROCESS_INSTANCE_VARIABLE_NEED_SIMULATE_PREFIX))); |
| 234 | 234 | } |
| 235 | 235 | // 移除运行中的节点，运行中的节点无需预测 |
| 236 | - // TODO @jason：是不是 foreach runActivityNodes，然后移除 needSimulateTaskDefKeysByReturn 更好？（理解成本低一点） | |
| 237 | - CollectionUtils.convertList(runActivityNodes, ActivityNode::getId).forEach(needSimulateTaskDefKeysByReturn::remove); | |
| 236 | + if (CollUtil.isNotEmpty(runActivityNodes)) { | |
| 237 | + runActivityNodes.forEach( activityNode -> { | |
| 238 | + needSimulateTaskDefKeysByReturn.remove(activityNode.getId()); | |
| 239 | + }); | |
| 240 | + } | |
| 238 | 241 | |
| 239 | 242 | // 3.3 预测未运行节点的审批信息 |
| 240 | 243 | List<ActivityNode> simulateActivityNodes = getSimulateApproveNodeList(startUserId, bpmnModel, | ... | ... |