code review：订单逻辑

YunaiV
1 parent 8dd600a3
Showing 2 changed files with 6 additions and 5 deletions
yudao-module-mall/yudao-module-trade-biz/src/main/java/cn/iocoder/yudao/module/trade/controller/admin/order/vo/TradeOrderDetailRespVO.java
yudao-module-mall/yudao-module-trade-biz/src/main/java/cn/iocoder/yudao/module/trade/service/order/TradeOrderQueryServiceImpl.java
@@ -26,10 +26,11 @@ public class TradeOrderDetailRespVO extends TradeOrderBaseVO {
     private MemberUserRespVO user;
     /**
-     * TODO 订单操作日志, 先模拟一波
+     * TODO 订单操作日志, 先模拟一波；返回 logs，简洁，然后复数哈
      */
     private List<OrderLog> orderLog;
+    // TODO @puhui999：swagger 注解
     @Data
     public static class OrderLog {
@@ -106,7 +106,7 @@ public class TradeOrderQueryServiceImpl implements TradeOrderQueryService {
             throw exception(ORDER_NOT_FOUND);
         }
-        return getTrackRespDTOs(order);
+        return getExpressTrackList(order);
     }
     @Override
@@ -117,16 +117,16 @@ public class TradeOrderQueryServiceImpl implements TradeOrderQueryService {
             throw exception(ORDER_NOT_FOUND);
         }
-        return getTrackRespDTOs(order);
+        return getExpressTrackList(order);
     }
     /**
-     * 得到物流轨迹
+     * 获得订单的物流轨迹
      *
      * @param order 订单
      * @return 物流轨迹
      */
-    private List<ExpressTrackRespDTO> getTrackRespDTOs(TradeOrderDO order) {
+    private List<ExpressTrackRespDTO> getExpressTrackList(TradeOrderDO order) {
         // 查询物流公司
         if (order.getLogisticsId() == null) {
             return Collections.emptyList();