Commit 2668e0cfebd0b3793d6698dfa66ecb4444e97c8e
1 parent
b9f1e8ff
📖 CRM:【产品】code review 产品的代码,补全对应的 todo list
Showing
4 changed files
with
10 additions
and
0 deletions
yudao-module-crm/yudao-module-crm-biz/src/main/java/cn/iocoder/yudao/module/crm/service/customer/CrmCustomerLimitConfigServiceImpl.java
| @@ -40,6 +40,7 @@ public class CrmCustomerLimitConfigServiceImpl implements CrmCustomerLimitConfig | @@ -40,6 +40,7 @@ public class CrmCustomerLimitConfigServiceImpl implements CrmCustomerLimitConfig | ||
| 40 | private AdminUserApi adminUserApi; | 40 | private AdminUserApi adminUserApi; |
| 41 | 41 | ||
| 42 | @Override | 42 | @Override |
| 43 | + // TODO @puhui999:操作日志 | ||
| 43 | public Long createCustomerLimitConfig(CrmCustomerLimitConfigCreateReqVO createReqVO) { | 44 | public Long createCustomerLimitConfig(CrmCustomerLimitConfigCreateReqVO createReqVO) { |
| 44 | validateUserAndDept(createReqVO.getUserIds(), createReqVO.getDeptIds()); | 45 | validateUserAndDept(createReqVO.getUserIds(), createReqVO.getDeptIds()); |
| 45 | // 插入 | 46 | // 插入 |
| @@ -50,6 +51,7 @@ public class CrmCustomerLimitConfigServiceImpl implements CrmCustomerLimitConfig | @@ -50,6 +51,7 @@ public class CrmCustomerLimitConfigServiceImpl implements CrmCustomerLimitConfig | ||
| 50 | } | 51 | } |
| 51 | 52 | ||
| 52 | @Override | 53 | @Override |
| 54 | + // TODO @puhui999:操作日志 | ||
| 53 | public void updateCustomerLimitConfig(CrmCustomerLimitConfigUpdateReqVO updateReqVO) { | 55 | public void updateCustomerLimitConfig(CrmCustomerLimitConfigUpdateReqVO updateReqVO) { |
| 54 | // 校验存在 | 56 | // 校验存在 |
| 55 | validateCustomerLimitConfigExists(updateReqVO.getId()); | 57 | validateCustomerLimitConfigExists(updateReqVO.getId()); |
| @@ -60,6 +62,7 @@ public class CrmCustomerLimitConfigServiceImpl implements CrmCustomerLimitConfig | @@ -60,6 +62,7 @@ public class CrmCustomerLimitConfigServiceImpl implements CrmCustomerLimitConfig | ||
| 60 | } | 62 | } |
| 61 | 63 | ||
| 62 | @Override | 64 | @Override |
| 65 | + // TODO @puhui999:操作日志 | ||
| 63 | public void deleteCustomerLimitConfig(Long id) { | 66 | public void deleteCustomerLimitConfig(Long id) { |
| 64 | // 校验存在 | 67 | // 校验存在 |
| 65 | validateCustomerLimitConfigExists(id); | 68 | validateCustomerLimitConfigExists(id); |
yudao-module-crm/yudao-module-crm-biz/src/main/java/cn/iocoder/yudao/module/crm/service/customer/CrmCustomerPoolConfigServiceImpl.java
| @@ -38,6 +38,7 @@ public class CrmCustomerPoolConfigServiceImpl implements CrmCustomerPoolConfigSe | @@ -38,6 +38,7 @@ public class CrmCustomerPoolConfigServiceImpl implements CrmCustomerPoolConfigSe | ||
| 38 | * @param saveReqVO 更新信息 | 38 | * @param saveReqVO 更新信息 |
| 39 | */ | 39 | */ |
| 40 | @Override | 40 | @Override |
| 41 | + // TODO @puhui999:操作日志 | ||
| 41 | public void saveCustomerPoolConfig(CrmCustomerPoolConfigSaveReqVO saveReqVO) { | 42 | public void saveCustomerPoolConfig(CrmCustomerPoolConfigSaveReqVO saveReqVO) { |
| 42 | // 存在,则进行更新 | 43 | // 存在,则进行更新 |
| 43 | CrmCustomerPoolConfigDO dbConfig = getCustomerPoolConfig(); | 44 | CrmCustomerPoolConfigDO dbConfig = getCustomerPoolConfig(); |
yudao-module-crm/yudao-module-crm-biz/src/main/java/cn/iocoder/yudao/module/crm/service/product/CrmProductCategoryServiceImpl.java
| @@ -35,6 +35,7 @@ public class CrmProductCategoryServiceImpl implements CrmProductCategoryService | @@ -35,6 +35,7 @@ public class CrmProductCategoryServiceImpl implements CrmProductCategoryService | ||
| 35 | private CrmProductService crmProductService; | 35 | private CrmProductService crmProductService; |
| 36 | 36 | ||
| 37 | @Override | 37 | @Override |
| 38 | + // TODO @puhui999:操作日志 | ||
| 38 | public Long createProductCategory(CrmProductCategoryCreateReqVO createReqVO) { | 39 | public Long createProductCategory(CrmProductCategoryCreateReqVO createReqVO) { |
| 39 | // 1.1 校验父分类存在 | 40 | // 1.1 校验父分类存在 |
| 40 | validateParentProductCategory(createReqVO.getParentId()); | 41 | validateParentProductCategory(createReqVO.getParentId()); |
| @@ -47,6 +48,7 @@ public class CrmProductCategoryServiceImpl implements CrmProductCategoryService | @@ -47,6 +48,7 @@ public class CrmProductCategoryServiceImpl implements CrmProductCategoryService | ||
| 47 | } | 48 | } |
| 48 | 49 | ||
| 49 | @Override | 50 | @Override |
| 51 | + // TODO @puhui999:操作日志 | ||
| 50 | public void updateProductCategory(CrmProductCategoryCreateReqVO updateReqVO) { | 52 | public void updateProductCategory(CrmProductCategoryCreateReqVO updateReqVO) { |
| 51 | // 1.1 校验存在 | 53 | // 1.1 校验存在 |
| 52 | validateProductCategoryExists(updateReqVO.getId()); | 54 | validateProductCategoryExists(updateReqVO.getId()); |
| @@ -91,6 +93,7 @@ public class CrmProductCategoryServiceImpl implements CrmProductCategoryService | @@ -91,6 +93,7 @@ public class CrmProductCategoryServiceImpl implements CrmProductCategoryService | ||
| 91 | } | 93 | } |
| 92 | 94 | ||
| 93 | @Override | 95 | @Override |
| 96 | + // TODO @puhui999:操作日志 | ||
| 94 | public void deleteProductCategory(Long id) { | 97 | public void deleteProductCategory(Long id) { |
| 95 | // 1.1 校验存在 | 98 | // 1.1 校验存在 |
| 96 | validateProductCategoryExists(id); | 99 | validateProductCategoryExists(id); |
yudao-module-crm/yudao-module-crm-biz/src/main/java/cn/iocoder/yudao/module/crm/service/product/CrmProductServiceImpl.java
| @@ -48,6 +48,7 @@ public class CrmProductServiceImpl implements CrmProductService { | @@ -48,6 +48,7 @@ public class CrmProductServiceImpl implements CrmProductService { | ||
| 48 | private AdminUserApi adminUserApi; | 48 | private AdminUserApi adminUserApi; |
| 49 | 49 | ||
| 50 | @Override | 50 | @Override |
| 51 | + // TODO @puhui999:操作日志 | ||
| 51 | public Long createProduct(CrmProductSaveReqVO createReqVO) { | 52 | public Long createProduct(CrmProductSaveReqVO createReqVO) { |
| 52 | // 校验产品 | 53 | // 校验产品 |
| 53 | adminUserApi.validateUserList(Collections.singleton(createReqVO.getOwnerUserId())); | 54 | adminUserApi.validateUserList(Collections.singleton(createReqVO.getOwnerUserId())); |
| @@ -66,6 +67,7 @@ public class CrmProductServiceImpl implements CrmProductService { | @@ -66,6 +67,7 @@ public class CrmProductServiceImpl implements CrmProductService { | ||
| 66 | } | 67 | } |
| 67 | 68 | ||
| 68 | @Override | 69 | @Override |
| 70 | + // TODO @puhui999:操作日志 | ||
| 69 | public void updateProduct(CrmProductSaveReqVO updateReqVO) { | 71 | public void updateProduct(CrmProductSaveReqVO updateReqVO) { |
| 70 | // 校验产品 | 72 | // 校验产品 |
| 71 | updateReqVO.setOwnerUserId(null); // 不修改负责人 | 73 | updateReqVO.setOwnerUserId(null); // 不修改负责人 |
| @@ -102,6 +104,7 @@ public class CrmProductServiceImpl implements CrmProductService { | @@ -102,6 +104,7 @@ public class CrmProductServiceImpl implements CrmProductService { | ||
| 102 | } | 104 | } |
| 103 | 105 | ||
| 104 | @Override | 106 | @Override |
| 107 | + // TODO @puhui999:操作日志 | ||
| 105 | public void deleteProduct(Long id) { | 108 | public void deleteProduct(Long id) { |
| 106 | // 校验存在 | 109 | // 校验存在 |
| 107 | validateProductExists(id); | 110 | validateProductExists(id); |