Commit 1b835e058fa1a8cc3d5994e56c1c45eda52654d2
1 parent
0d2ae6be
修改code review
Showing
1 changed file
with
2 additions
and
0 deletions
yudao-admin-server/src/main/java/cn/iocoder/yudao/adminserver/modules/activiti/controller/oa/OALeaveController.java
| @@ -41,6 +41,7 @@ public class OALeaveController { | @@ -41,6 +41,7 @@ public class OALeaveController { | ||
| 41 | @PreAuthorize("@ss.hasPermission('oa:leave:create')") | 41 | @PreAuthorize("@ss.hasPermission('oa:leave:create')") |
| 42 | public CommonResult<Long> createLeave(@Valid @RequestBody OALeaveCreateReqVO createReqVO) { | 42 | public CommonResult<Long> createLeave(@Valid @RequestBody OALeaveCreateReqVO createReqVO) { |
| 43 | // TODO @芋艿：processKey 自己去理解下。不过得把 leave 变成枚举 | 43 | // TODO @芋艿：processKey 自己去理解下。不过得把 leave 变成枚举 |
| 44 | + // TODO @芋艿 该方法没有用到， 是前一个版本的， 可以删掉。 | ||
| 44 | createReqVO.setProcessKey("leave"); | 45 | createReqVO.setProcessKey("leave"); |
| 45 | return success(leaveService.createLeave(createReqVO)); | 46 | return success(leaveService.createLeave(createReqVO)); |
| 46 | } | 47 | } |
| @@ -49,6 +50,7 @@ public class OALeaveController { | @@ -49,6 +50,7 @@ public class OALeaveController { | ||
| 49 | @ApiOperation("创建外置请假申请") | 50 | @ApiOperation("创建外置请假申请") |
| 50 | public CommonResult<Long> createFormKeyLeave(@Valid @RequestBody OALeaveCreateReqVO createReqVO) { | 51 | public CommonResult<Long> createFormKeyLeave(@Valid @RequestBody OALeaveCreateReqVO createReqVO) { |
| 51 | // TODO @芋艿：processKey 自己去理解下。不过得把 formkey 变成枚举 | 52 | // TODO @芋艿：processKey 自己去理解下。不过得把 formkey 变成枚举 |
| 53 | + // TODO @芋艿 : processKey 是 bpmn <process> 中定义的id, 提交业务表单时候， 需要启动流程， 或许从前台传更合适 | ||
| 52 | createReqVO.setProcessKey("leave-formkey"); | 54 | createReqVO.setProcessKey("leave-formkey"); |
| 53 | return success(leaveService.createLeave(createReqVO)); | 55 | return success(leaveService.createLeave(createReqVO)); |
| 54 | } | 56 | } |