Commit 120e4415a95994173f223c4304f28b0d2fba67d0
1 parent
bd29116e
feat(im):清理多余的 TODO
Showing
6 changed files
with
2 additions
and
10 deletions
yudao-module-im/src/main/java/cn/iocoder/yudao/module/im/controller/admin/manager/channel/ImChannelManagerController.java
| @@ -75,7 +75,6 @@ public class ImChannelManagerController { | @@ -75,7 +75,6 @@ public class ImChannelManagerController { | ||
| 75 | @GetMapping("/simple-list") | 75 | @GetMapping("/simple-list") |
| 76 | @Operation(summary = "获得启用的频道精简列表;前端表单选择频道时调用") | 76 | @Operation(summary = "获得启用的频道精简列表;前端表单选择频道时调用") |
| 77 | public CommonResult<List<ImChannelRespVO>> getSimpleChannelList() { | 77 | public CommonResult<List<ImChannelRespVO>> getSimpleChannelList() { |
| 78 | - // TODO DONE @AI:getChannelListByStatus 统一命名 | ||
| 79 | List<ImChannelDO> list = channelService.getChannelListByStatus(CommonStatusEnum.ENABLE.getStatus()); | 78 | List<ImChannelDO> list = channelService.getChannelListByStatus(CommonStatusEnum.ENABLE.getStatus()); |
| 80 | return success(BeanUtils.toBean(list, ImChannelRespVO.class)); | 79 | return success(BeanUtils.toBean(list, ImChannelRespVO.class)); |
| 81 | } | 80 | } |
yudao-module-im/src/main/java/cn/iocoder/yudao/module/im/enums/message/ImMessageTypeEnum.java
| @@ -127,10 +127,6 @@ public enum ImMessageTypeEnum implements ArrayValuable<Integer> { | @@ -127,10 +127,6 @@ public enum ImMessageTypeEnum implements ArrayValuable<Integer> { | ||
| 127 | RTC_CALL_END(1611, "通话结束", true, false), | 127 | RTC_CALL_END(1611, "通话结束", true, false), |
| 128 | 128 | ||
| 129 | // ========== 好友通知(1201-1210 直接复用 OpenIM 段位编号) ========== | 129 | // ========== 好友通知(1201-1210 直接复用 OpenIM 段位编号) ========== |
| 130 | - // TODO @芋艿:FRIEND_REQUEST_* 与 GROUP_REQUEST_* 都是 persistent=false 的 SysMsg,离线 pull 拉不到, | ||
| 131 | - // 目前可能丢失「实时 toast 提醒」体验(业务状态不丢,前端上线 fetch{Friend,Group}RequestList 能补回来); | ||
| 132 | - // 未来思考下怎么优化:候选方案 1)改 persistent=true 入私聊消息流 + 让客户端按 type 自渲染; | ||
| 133 | - // 2)服务端补一个「未读通知拉取」接口给前端冷启动调用。 | ||
| 134 | /** | 130 | /** |
| 135 | * 对应 OpenIM:FriendApplicationApprovedNotification 1201 | 131 | * 对应 OpenIM:FriendApplicationApprovedNotification 1201 |
| 136 | * 对应自己的类:FriendRequestApprovedNotification | 132 | * 对应自己的类:FriendRequestApprovedNotification |
yudao-module-im/src/main/java/cn/iocoder/yudao/module/im/enums/rtc/ImRtcParticipantStatusEnum.java
| @@ -24,7 +24,6 @@ import java.util.Objects; | @@ -24,7 +24,6 @@ import java.util.Objects; | ||
| 24 | @Getter | 24 | @Getter |
| 25 | public enum ImRtcParticipantStatusEnum implements ArrayValuable<Integer> { | 25 | public enum ImRtcParticipantStatusEnum implements ArrayValuable<Integer> { |
| 26 | 26 | ||
| 27 | - // TODO @芋艿:hand up 要不要也搞下。 | ||
| 28 | INVITING(10, "邀请中"), // 已发出 invite,等被叫响应 | 27 | INVITING(10, "邀请中"), // 已发出 invite,等被叫响应 |
| 29 | JOINED(20, "已加入"), // 已 connect 进 LiveKit 房间 | 28 | JOINED(20, "已加入"), // 已 connect 进 LiveKit 房间 |
| 30 | REJECTED(30, "已拒绝"), // 接通前点拒接 | 29 | REJECTED(30, "已拒绝"), // 接通前点拒接 |
yudao-module-im/src/main/java/cn/iocoder/yudao/module/im/service/group/ImGroupMemberServiceImpl.java
| @@ -76,7 +76,6 @@ public class ImGroupMemberServiceImpl implements ImGroupMemberService { | @@ -76,7 +76,6 @@ public class ImGroupMemberServiceImpl implements ImGroupMemberService { | ||
| 76 | 76 | ||
| 77 | @Override | 77 | @Override |
| 78 | public List<ImGroupMemberDO> getGroupMemberListByOwnerAndAdmin(Long groupId) { | 78 | public List<ImGroupMemberDO> getGroupMemberListByOwnerAndAdmin(Long groupId) { |
| 79 | - // TODO DONE @AI:把条件往下传;这样减少加载数据量! | ||
| 80 | return groupMemberMapper.selectListByGroupIdAndStatusAndRoles(groupId, CommonStatusEnum.ENABLE.getStatus(), | 79 | return groupMemberMapper.selectListByGroupIdAndStatusAndRoles(groupId, CommonStatusEnum.ENABLE.getStatus(), |
| 81 | List.of(ImGroupMemberRoleEnum.OWNER.getRole(), ImGroupMemberRoleEnum.ADMIN.getRole())); | 80 | List.of(ImGroupMemberRoleEnum.OWNER.getRole(), ImGroupMemberRoleEnum.ADMIN.getRole())); |
| 82 | } | 81 | } |
yudao-module-im/src/main/java/cn/iocoder/yudao/module/im/service/rtc/ImRtcCallServiceImpl.java
| @@ -707,7 +707,6 @@ public class ImRtcCallServiceImpl implements ImRtcCallService { | @@ -707,7 +707,6 @@ public class ImRtcCallServiceImpl implements ImRtcCallService { | ||
| 707 | } | 707 | } |
| 708 | 708 | ||
| 709 | // 3.1 群通话:推 RTC_CALL(NO_ANSWER) 让前端 banner 移除该人 + 级联关房判定 | 709 | // 3.1 群通话:推 RTC_CALL(NO_ANSWER) 让前端 banner 移除该人 + 级联关房判定 |
| 710 | - // TODO DONE @AI:拆分独立 NO_ANSWER 信令,不再复用 REJECT | ||
| 711 | if (ImConversationTypeEnum.isGroup(call.getConversationType())) { | 710 | if (ImConversationTypeEnum.isGroup(call.getConversationType())) { |
| 712 | pushCallNoAnswerNotification(call, userId, userMap.get(userId)); | 711 | pushCallNoAnswerNotification(call, userId, userMap.get(userId)); |
| 713 | endSessionIfTerminal(call, userId); | 712 | endSessionIfTerminal(call, userId); |
yudao-module-im/src/test/resources/sql/create_tables.sql
| @@ -26,7 +26,7 @@ CREATE TABLE IF NOT EXISTS "im_group_message" ( | @@ -26,7 +26,7 @@ CREATE TABLE IF NOT EXISTS "im_group_message" ( | ||
| 26 | "content" varchar(8192) DEFAULT NULL COMMENT '消息内容', | 26 | "content" varchar(8192) DEFAULT NULL COMMENT '消息内容', |
| 27 | "status" tinyint NOT NULL COMMENT '消息状态', | 27 | "status" tinyint NOT NULL COMMENT '消息状态', |
| 28 | "send_time" timestamp NOT NULL COMMENT '发送时间', | 28 | "send_time" timestamp NOT NULL COMMENT '发送时间', |
| 29 | - "receiver_user_ids" varchar(1024) DEFAULT NULL COMMENT '定向接收用户编号列表', | 29 | + "receiver_user_ids" text DEFAULT NULL COMMENT '定向接收用户编号列表', |
| 30 | "at_user_ids" varchar(1024) DEFAULT NULL COMMENT '@ 目标用户编号列表', | 30 | "at_user_ids" varchar(1024) DEFAULT NULL COMMENT '@ 目标用户编号列表', |
| 31 | "receipt_status" tinyint NOT NULL DEFAULT 0 COMMENT '回执状态', | 31 | "receipt_status" tinyint NOT NULL DEFAULT 0 COMMENT '回执状态', |
| 32 | "creator" varchar(64) DEFAULT '', | 32 | "creator" varchar(64) DEFAULT '', |
| @@ -281,7 +281,7 @@ CREATE TABLE IF NOT EXISTS "im_channel_message" ( | @@ -281,7 +281,7 @@ CREATE TABLE IF NOT EXISTS "im_channel_message" ( | ||
| 281 | "material_id" bigint NOT NULL COMMENT '关联素材编号', | 281 | "material_id" bigint NOT NULL COMMENT '关联素材编号', |
| 282 | "type" smallint NOT NULL COMMENT '消息类型', | 282 | "type" smallint NOT NULL COMMENT '消息类型', |
| 283 | "content" varchar(8192) DEFAULT NULL COMMENT '消息内容;推送时 payload JSON 快照;不含富文本正文', | 283 | "content" varchar(8192) DEFAULT NULL COMMENT '消息内容;推送时 payload JSON 快照;不含富文本正文', |
| 284 | - "receiver_user_ids" varchar(1024) DEFAULT NULL COMMENT '接收人编号列表;逗号分隔;为空表示全员', | 284 | + "receiver_user_ids" text DEFAULT NULL COMMENT '接收人编号列表;逗号分隔;为空表示全员', |
| 285 | "send_time" timestamp NOT NULL COMMENT '发送时间', | 285 | "send_time" timestamp NOT NULL COMMENT '发送时间', |
| 286 | "creator" varchar(64) DEFAULT '', | 286 | "creator" varchar(64) DEFAULT '', |
| 287 | "create_time" timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP, | 287 | "create_time" timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP, |